-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update inspector_protocol to c149e90e9ff5bf7 #37574
Conversation
See #27770 Last time I updated |
Also see https://github.com/nodejs/node/commits/master/tools/inspector_protocol for the fixes that we float on top of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM (and assuming Jinga 2 is now a dependency)
7165d33
to
1d993ec
Compare
In the current code on |
PR-URL: nodejs#29296 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
30f4a66
to
fa98a8b
Compare
It seems there are a lot of breaking changes in the update, I'm starting to wonder if I haven't pick a challenge too big for my skills. |
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Hopefully this should fix the
linux-coverage
GitHub Action.To update it, I used the following commands:
Then I had to update
src/inspector/node_inspector.gypi
to reflect the changes intools/inspector_protocol/inspector_protocol.gni
.