Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mac coverage with webcrypto tests #37571

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Improve mac coverage with webcrypto tests #37571

merged 1 commit into from
Mar 8, 2021

Conversation

obi-el
Copy link
Contributor

@obi-el obi-el commented Mar 2, 2021

test: Added webcrypto tests for HMAC to improve the coverage of the file lib/internal/crypto/mac.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 2, 2021
@aduh95
Copy link
Contributor

aduh95 commented Mar 7, 2021

assert.rejects returns a Promise, we must ensure that Promise is not still pending at the end of the test. You need to either add .then(common.mustCall()) after each assert.rejects calls, or put in an async test function as it's done in the same file below.

@obi-el
Copy link
Contributor Author

obi-el commented Mar 7, 2021

assert.rejects returns a Promise, we must ensure that Promise is not still pending at the end of the test. You need to either add .then(common.mustCall()) after each assert.rejects calls, or put in an async test function as it's done in the same file below.

Thanks for the comment, i've made the change

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36527/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36529/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36530/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36531/

@aduh95
Copy link
Contributor

aduh95 commented Mar 8, 2021 •
edited
Loading

Landed in 4811210, thanks a lot 🎉

@aduh95 aduh95 merged commit 4811210 into nodejs:master Mar 8, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@obi-el @danielleadams
crypto,test: improve hmac coverage with webcrypto tests
23d6541 
PR-URL: #37571
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@obi-el @aduh95 @nodejs-github-bot @Trott @targos