Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typos in /doc/api/fs.md #37557

Closed
wants to merge 1 commit into from
Closed

doc: fix typos in /doc/api/fs.md #37557

wants to merge 1 commit into from

Conversation

Luntke
Copy link
Contributor

@Luntke Luntke commented Mar 1, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 1, 2021
mhdawson
mhdawson approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PoojaDurgad PoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
@mhdawson
Copy link
Member

mhdawson commented Mar 8, 2021

Doc only and action linters green, landing

mhdawson pushed a commit that referenced this pull request Mar 8, 2021
@Luntke @mhdawson
doc: fix typos in /doc/api/fs.md
97ebcdd 
PR-URL: #37557
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@mhdawson
Copy link
Member

mhdawson commented Mar 8, 2021

Landed in 97ebcdd

@mhdawson mhdawson closed this Mar 8, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@Luntke @danielleadams
doc: fix typos in /doc/api/fs.md
e4c8c50 
PR-URL: #37557
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
@aduh95 aduh95 mentioned this pull request Sep 1, 2021
Closed
targos pushed a commit that referenced this pull request Sep 4, 2021
@Luntke @targos
doc: fix typos in /doc/api/fs.md
f9d36cb 
PR-URL: #37557
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.