tools: fix lint-pr-url message #37304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
reviewed
Feb 10, 2021
RaisinTen
approved these changes
Feb 10, 2021
lpinca
approved these changes
Feb 10, 2021
Trott
approved these changes
Feb 10, 2021
It does run on backport PRs, and does produce "false positives" warnings. E.G.: https://github.com/nodejs/node/pull/37289/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63R463 I was aware of this when working on this, so I made sure it never produces errors and always completes as green. If people find it too noisy, we can maybe filter out the backport PR somehow. |
aduh95
added
the
author ready
PR-URL: nodejs#37304 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in a803d4a |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37304 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37304 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actual PR URLmessage may be a bit confusing, this PR specifies it's talking about the current PR.