Updating upload.zip to be an uncorrupted version of the file #37294
Conversation
|
The file was copied using |
Seems like a bug (or I'm not understanding the command). |
We probably don't run the test that uses this file. Currently we pull the FileAPI tests only to run the ones that test the |
aduh95
added
the
author ready
You'd need to remove the hash in |
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
|
PR to fix |
|
Landed in 574590d |
PR-URL: #37294 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
|
Just for my knowledge, when would this get rolled into a release if its been merged into master? |
Since it's a patch-fix, it will probably be in the next 15.x release, probably two weeks or so from now. Of course, since it's a test, it won't affect end users running |
PR-URL: #37294 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #37294 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #37294 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #37294 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
I noticed that the file in question seemed to be corrupted and could not be unzipped. The original source of the file was copied from https://github.com/web-platform-tests/wpt/blob/master/FileAPI/filelist-section/support/upload.zip, so i replaced the version in the node repository with the original version of the file and confirmed that it was able to be unzipped.