Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Corrected misnamed mention of SHASUMS256.txt in README.md #37260

Closed
wants to merge 1 commit into from
Closed

doc: Corrected misnamed mention of SHASUMS256.txt in README.md #37260

wants to merge 1 commit into from

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Feb 7, 2021

Corrected the SHASUMS256.txt file name in README.md

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 7, 2021
@marsonya marsonya changed the title doc: SHASUMS256.txt misnamed as SHASUM256.txt in README.md doc: Corrected misnamed mention of SHASUMS256.txt in README.md Feb 7, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2021
MylesBorins
MylesBorins approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

richardlau pushed a commit that referenced this pull request Feb 9, 2021
@marsonya @richardlau
doc: fix misnamed SHASUMS256.txt name in README.md
39d4d14 
PR-URL: #37260
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@richardlau
Copy link
Member

Landed in 39d4d14

@richardlau richardlau closed this Feb 9, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@marsonya @danielleadams
doc: fix misnamed SHASUMS256.txt name in README.md
85bed2e 
PR-URL: #37260
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
doc: fix misnamed SHASUMS256.txt name in README.md
8c41bc9 
PR-URL: #37260
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@marsonya @richardlau @MylesBorins @Trott @lpinca @tniessen @BethGriggs @RaisinTen @nodejs-github-bot