doc: rename N-API to Node-API #37259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
added
doc
richardlau
reviewed
Feb 7, 2021
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 8, 2021
This is a prerequisite for nodejs#37259.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 8, 2021
This is a prerequisite for nodejs#37259. PR-URL: nodejs#37270 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Trott
force-pushed
the
rename-n-api-doc
branch
from
5840edb
to
ac99f0c
Compare
gireeshpunathil
approved these changes
Feb 8, 2021
gabrielschulhof
force-pushed
the
rename-n-api-doc
branch
from
90e8550
to
ac99f0c
Compare
gabrielschulhof
pushed a commit
that referenced
this pull request
Feb 8, 2021
Refs: nodejs/abi-stable-node#420 PR-URL: #37259 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 2084f31. |
ExE-Boss
suggested changes
Feb 9, 2021
| @@ -33,14 +32,14 @@ properties: | |||
| using `napi_get_last_error_info`. More information can be found in the error | |||
| handling section [Error handling][]. | |||
|
|
|||
| The N-API is a C API that ensures ABI stability across Node.js versions | |||
| Node-API-API is a C API that ensures ABI stability across Node.js versions | |||
There was a problem hiding this comment.
Suggested change
| Node-API-API is a C API that ensures ABI stability across Node.js versions | |
| Node-API is a C API that ensures ABI stability across Node.js versions |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
This is a prerequisite for #37259. PR-URL: #37270 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
Refs: nodejs/abi-stable-node#420 PR-URL: #37259 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: nodejs/abi-stable-node#420 PR-URL: #37259 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This is a prerequisite for #37259. PR-URL: #37270 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
This is a prerequisite for #37259. PR-URL: #37270 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.