Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix pr-url for DEP0148 #37205

Merged
merged 1 commit into from
Feb 3, 2021
Merged

doc: fix pr-url for DEP0148 #37205

merged 1 commit into from
Feb 3, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 3, 2021 •
edited
Loading

Was pointing to #35746 instead of #35747.

@aduh95 aduh95 added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 3, 2021
@nodejs-github-bot nodejs-github-bot added the deprecations Issues and PRs related to deprecations. label Feb 3, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 3, 2021

fast-track?

@aduh95
doc: fix pr-url for DEP0148
b586c6a 
PR-URL: nodejs#37205
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 3, 2021

Landed in b586c6a

@aduh95 aduh95 closed this Feb 3, 2021
@aduh95 aduh95 merged commit b586c6a into nodejs:master Feb 3, 2021
@aduh95 aduh95 deleted the fix-pr-url-DEP0148 branch February 3, 2021 14:54
@aduh95 aduh95 mentioned this pull request Feb 4, 2021
Merged
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@aduh95 @danielleadams
doc: fix pr-url for DEP0148
3f815d9 
PR-URL: #37205
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Feb 16, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @jasnell @richardlau @BethGriggs @Lxxyx @RaisinTen @PoojaDurgad @targos @nodejs-github-bot