src: fix return type of method in string_search.h #37167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Feb 1, 2021
jasnell
approved these changes
Feb 1, 2021
lpinca
approved these changes
Feb 1, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
marsonya
approved these changes
Feb 3, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Feb 6, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`Vector::forward()` is supposed to return a `bool`.
RaisinTen
force-pushed
the
src/fix-type-in-string_search.h
branch
from
34af3e0
to
053938e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RaisinTen
added a commit
that referenced
this pull request
Feb 10, 2021
`Vector::forward()` is supposed to return a `bool`. PR-URL: #37167 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in e045dda 🎉 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
`Vector::forward()` is supposed to return a `bool`. PR-URL: #37167 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
`Vector::forward()` is supposed to return a `bool`. PR-URL: #37167 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector::forward()is supposed to return abool.