[v12.x backport] worker: add eventLoopUtilization() #37165

juanarbol · 2021-02-01T03:31:54Z

Allow calling eventLoopUtilization() directly on a worker thread:

const worker = new Worker('./foo.js');
const elu = worker.performance.eventLoopUtilization();
setTimeout(() => {
  worker.performance.eventLoopUtilization(elu);
}, 10);

Add a new performance object on the Worker instance that will hopefully
one day hold all the other performance metrics, such as nodeTiming.

Include benchmarks and tests.

PR-URL: #35664
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Gerhard Stöbich [email protected]
Reviewed-By: James M Snell [email protected]

Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: nodejs#35664 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#37165

nodejs-github-bot · 2021-02-01T03:36:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35848/

nodejs-github-bot · 2021-02-01T16:13:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35861/

richardlau · 2021-02-01T16:23:22Z

Does this include #35891?

juanarbol · 2021-02-01T16:23:59Z

Does this include #35891?

Nope, let me work on that for both backport PRs

juanarbol · 2021-02-01T16:37:46Z

@richardlau should I squash #35891 with #35664 ? or basically follow the steps described in the backporting guide (here) for both commits ?

juanarbol · 2021-02-01T17:46:10Z

The node-test-commit-custom-suites-freestyle (test-worker) tests failed in both CIs, I'll take a closer look.

The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Backport-PR-URL: nodejs#37165

nodejs-github-bot · 2021-02-01T19:19:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35868/

Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: nodejs#35664 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#37165

The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Backport-PR-URL: nodejs#37165

juanarbol · 2021-02-22T20:24:29Z

@richardlau is there anything missing here?

richardlau · 2021-03-02T18:01:50Z

@juanarbol Could you rebase this onto the current v12.x-staging please?

Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: nodejs#35664 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#37165

The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Backport-PR-URL: nodejs#37165

Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: nodejs#35664 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#37165

The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Backport-PR-URL: nodejs#37165

juanarbol · 2021-03-02T20:34:50Z

@richardlau Rebased!

nodejs-github-bot · 2021-03-02T22:55:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36458/

nodejs-github-bot · 2021-03-07T22:51:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36528/

richardlau · 2021-03-08T11:14:14Z

@juanarbol parallel/test-bootstrap-modules is failing with workers (python tools/test.py --worker parallel/test-bootstrap-modules). It looks like the test change from https://github.com/nodejs/node/pull/35664/files#diff-eeda4d549f43051fb9ffbc8286e838ebfd607bae681dfc55a76679e6705124f9 is missing here?

The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Backport-PR-URL: nodejs#37165

nodejs-github-bot · 2021-03-09T00:02:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36554/

juanarbol · 2021-03-09T12:20:35Z

@richardlau, your review is addressed :) I think this is ready to be landed.

Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: nodejs#35664 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#37165

The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Backport-PR-URL: nodejs#37165

richardlau · 2021-03-16T00:23:38Z

Landed in 0f6d445...d7a4ccd

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Feb 1, 2021

juanarbol changed the title ~~worker: add eventLoopUtilization()~~ [12.x backport] worker: add eventLoopUtilization() Feb 1, 2021

juanarbol changed the title ~~[12.x backport] worker: add eventLoopUtilization()~~ [v12.x backport] worker: add eventLoopUtilization() Feb 1, 2021

juanarbol force-pushed the backport-35664-to-12.x branch from 5bbaeb0 to 542c56f Compare February 1, 2021 03:34

jasnell approved these changes Feb 1, 2021

View reviewed changes

richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 1, 2021

ruyadorno force-pushed the v12.x-staging branch from 97183ae to 4ac8f37 Compare February 10, 2021 03:16

juanarbol force-pushed the backport-35664-to-12.x branch from 344f7ff to e132479 Compare February 10, 2021 21:49

richardlau force-pushed the v12.x-staging branch from 0692611 to 6cef0e3 Compare February 23, 2021 12:51

This comment has been minimized.

Sign in to view

juanarbol force-pushed the backport-35664-to-12.x branch from e132479 to 77ef942 Compare March 2, 2021 20:23

juanarbol force-pushed the backport-35664-to-12.x branch from 77ef942 to 2e3251e Compare March 2, 2021 20:25

This comment has been minimized.

Sign in to view

juanarbol force-pushed the backport-35664-to-12.x branch from 2e3251e to e663156 Compare March 8, 2021 20:38

juanarbol force-pushed the backport-35664-to-12.x branch from e663156 to 280d3c2 Compare March 8, 2021 21:14

richardlau approved these changes Mar 16, 2021

View reviewed changes

trevnorris and others added 2 commits March 16, 2021 00:04

richardlau force-pushed the backport-35664-to-12.x branch from 280d3c2 to d7a4ccd Compare March 16, 2021 00:22

richardlau merged commit d7a4ccd into nodejs:v12.x-staging Mar 16, 2021

juanarbol deleted the backport-35664-to-12.x branch August 26, 2021 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v12.x backport] worker: add eventLoopUtilization() #37165

[v12.x backport] worker: add eventLoopUtilization() #37165

juanarbol commented Feb 1, 2021 •

edited

Loading

nodejs-github-bot commented Feb 1, 2021

nodejs-github-bot commented Feb 1, 2021

richardlau commented Feb 1, 2021

juanarbol commented Feb 1, 2021

juanarbol commented Feb 1, 2021

juanarbol commented Feb 1, 2021

nodejs-github-bot commented Feb 1, 2021

juanarbol commented Feb 22, 2021

This comment has been minimized.

richardlau commented Mar 2, 2021

juanarbol commented Mar 2, 2021

This comment has been minimized.

nodejs-github-bot commented Mar 2, 2021

nodejs-github-bot commented Mar 7, 2021

richardlau commented Mar 8, 2021

nodejs-github-bot commented Mar 9, 2021

juanarbol commented Mar 9, 2021

richardlau commented Mar 16, 2021

[v12.x backport] worker: add eventLoopUtilization() #37165

[v12.x backport] worker: add eventLoopUtilization() #37165

Conversation

juanarbol commented Feb 1, 2021 • edited Loading

nodejs-github-bot commented Feb 1, 2021

nodejs-github-bot commented Feb 1, 2021

richardlau commented Feb 1, 2021

juanarbol commented Feb 1, 2021

juanarbol commented Feb 1, 2021

juanarbol commented Feb 1, 2021

nodejs-github-bot commented Feb 1, 2021

juanarbol commented Feb 22, 2021

This comment has been minimized.

richardlau commented Mar 2, 2021

juanarbol commented Mar 2, 2021

This comment has been minimized.

nodejs-github-bot commented Mar 2, 2021

nodejs-github-bot commented Mar 7, 2021

richardlau commented Mar 8, 2021

nodejs-github-bot commented Mar 9, 2021

juanarbol commented Mar 9, 2021

richardlau commented Mar 16, 2021

juanarbol commented Feb 1, 2021 •

edited

Loading