test: process.nextTick for beforeExit case #37012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Jan 21, 2021
This comment has been minimized.
This comment has been minimized.
Flarna
approved these changes
Jan 21, 2021
Flarna
added
the
author ready
lpinca
approved these changes
Jan 22, 2021
Co-authored-by: Luigi Pinca <[email protected]>
Trott
reviewed
Jan 24, 2021
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jan 24, 2021
|
Welcome @ttzztztz and thanks for the pull request! |
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Jan 24, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
reviewed
Jan 25, 2021
aduh95
reviewed
Jan 25, 2021
jasnell
pushed a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #37012 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 1377163 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #37012 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37012 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for test case
test/parallel/test-process-beforeexit.jsto test the behavior ofprocess.nextTickwithprocess.on('beforeExit', ()=>{})event