Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add miladfarca to collaborators #36934

Closed
wants to merge 1 commit into from
Closed

doc: add miladfarca to collaborators #36934

wants to merge 1 commit into from

Conversation

miladfarca
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 14, 2021
@miladfarca miladfarca added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 14, 2021
@miladfarca
Copy link
Contributor Author

Please 👍 this comment to approve fast-tracking.

mhdawson
mhdawson approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome !

@miladfarca miladfarca removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35556/

miladfarca added a commit that referenced this pull request Jan 15, 2021
@miladfarca
doc: add miladfarca to collaborators
d22f16d 
PR-URL: #36934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@miladfarca
Copy link
Contributor Author

Landed in d22f16d. Thank you.

@miladfarca miladfarca closed this Jan 15, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@miladfarca @ruyadorno
doc: add miladfarca to collaborators
80c84a1 
PR-URL: #36934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno added a commit that referenced this pull request Jan 22, 2021
@ruyadorno
2021-01-22, Version 15.7.0 (Current)
78b8cde 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* crypto:
  * experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) [#36879](#36879)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno added a commit that referenced this pull request Jan 25, 2021
@ruyadorno
2021-01-22, Version 15.7.0 (Current)
5fe188e 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno added a commit that referenced this pull request Jan 25, 2021
@ruyadorno
2021-01-26, Version 15.7.0 (Current)
2c0edbc 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno added a commit that referenced this pull request Jan 26, 2021
@ruyadorno
2021-01-26, Version 15.7.0 (Current)
cef00ad 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
targos pushed a commit that referenced this pull request May 1, 2021
@miladfarca @targos
doc: add miladfarca to collaborators
ed5bb76 
PR-URL: #36934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
This was referenced Nov 8, 2022
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 8, 2022
Open
@kissofire kissofire mentioned this pull request Nov 8, 2022
Open
@137717unity 137717unity mentioned this pull request Nov 9, 2022
Open
@baby636 baby636 mentioned this pull request Nov 9, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Nov 9, 2022
Open
@kissofire kissofire mentioned this pull request Mar 18, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jun 8, 2023
Open
This was referenced Jun 8, 2023
Open
Open
@ron-a20 ron-a20 mentioned this pull request Jun 8, 2023
Open
@baby636 baby636 mentioned this pull request Jun 9, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 9, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 9, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 21, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 21, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 21, 2023
Open
@baby636 baby636 mentioned this pull request Jun 23, 2023
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Oct 1, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
@kissofire kissofire mentioned this pull request Oct 1, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 2, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Oct 2, 2023
Open
@137717unity 137717unity mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Oct 2, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Feb 23, 2024
Open
@kissofire kissofire mentioned this pull request Feb 23, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Feb 23, 2024
Open
@baby636 baby636 mentioned this pull request Feb 23, 2024
Open
@137717unity 137717unity mentioned this pull request Feb 23, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Feb 24, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@Flarna Flarna Flarna approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@miladfarca @nodejs-github-bot @jasnell @Trott @richardlau @gireeshpunathil @mhdawson @Flarna @PoojaDurgad