src: use BaseObject::kInternalFieldCount in X509Certificate constructor #36892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use defined constant instead of hard-coding the field count
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Jan 12, 2021
jasnell
approved these changes
Jan 12, 2021
aduh95
added
author ready
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2021
Use defined constant instead of hard-coding the field count PR-URL: #36892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 3ede3c2 |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
Use defined constant instead of hard-coding the field count PR-URL: #36892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
Use defined constant instead of hard-coding the field count PR-URL: #36892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use defined constant instead of hard-coding the field count