Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix compiling against openssl with no-psk #36881

Closed
wants to merge 1 commit into from
Closed

build: fix compiling against openssl with no-psk #36881

wants to merge 1 commit into from

Commits on Jan 13, 2021

  1. build: fix compiling against openssl with no-psk 

    fixes nodejs#36464

Node 15 prior to this commit will not compile if openssl is built with
no-psk. Compiling emits an error like this:

```
crypto_tls.cc:(.text+0x4c27): undefined reference to `node::crypto::TLSWrap::SetCACerts(node::crypto::SecureContext*)'
```

Blame on crypto_tls.cc shows the file was created in a refactor. Before
that refactor SetCACerts was defined outside OPENSSL_NO_PSK ifndef

https://github.com/nodejs/node/blob/6751b6dc3da102f259b74b7453032edadc7a37ca/src/crypto/crypto_ssl.cc#L839
    Caleb ツ Everett committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    7f41ffd View commit details
    Browse the repository at this point in the history