test: use faster variant for rss in test-crypto-dh-leak.js #36766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
approved these changes
Jan 4, 2021
Trott
requested changes
Jan 5, 2021
There was a problem hiding this comment.
Change looks good to me but it's not desirable (in my opinion, at least) to have multiple identical commit messages. Can we please update the commit message for this and the other PRs with identical names/commit messages so that they indicate the name of the test that is being changed?
PoojaDurgad
changed the title
yeah, fixed |
Trott
approved these changes
Jan 5, 2021
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
PoojaDurgad
added
the
author ready
jasnell
approved these changes
Jan 11, 2021
|
Landed in f4ef517 |
jasnell
pushed a commit
that referenced
this pull request
Jan 11, 2021
PR-URL: #36766 Refs: #34291 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36766 Refs: #34291 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Aug 8, 2021
PR-URL: #36766 Refs: #34291 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 12, 2021
PR-URL: #36766 Refs: #34291 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 31, 2021
PR-URL: #36766 Refs: #34291 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#36766 Refs: nodejs#34291 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #34291
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes