doc: clarify undocumented stream properties #36715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
reviewed
Jan 2, 2021
Trott
reviewed
Jan 2, 2021
Trott
reviewed
Jan 2, 2021
Trott
approved these changes
Jan 2, 2021
|
I suggested removing "undocumented" in one of my comments because we're talking about them in the documentation, so they're not exactly undocumented. So I'd also suggest removing it from the commit message. (If removing it doesn't feel right, maybe change it to "unsupported"?) |
jasnell
commented
Jan 2, 2021
jasnell
commented
Jan 2, 2021
jasnell
commented
Jan 2, 2021
Fixes: nodejs#28592 Signed-off-by: James M Snell <[email protected]>
jasnell
force-pushed
the
clarify-undocumented-stream-properties
branch
from
28402fe
to
dc2e838
Compare
ronag
approved these changes
Jan 3, 2021
targos
approved these changes
Jan 3, 2021
|
Landed in 7cfa1be |
jasnell
added a commit
that referenced
this pull request
Jan 3, 2021
Fixes: #28592 Signed-off-by: James M Snell <[email protected]> PR-URL: #36715 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Fixes: #28592 Signed-off-by: James M Snell <[email protected]> PR-URL: #36715 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fixes: #28592 Signed-off-by: James M Snell <[email protected]> PR-URL: #36715 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28592
Signed-off-by: James M Snell [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes