test: add test for reused AbortController with execfile() #36644

Trott · 2020-12-27T17:45:42Z

Test that reusing an aborted AbortController with execfile() results in
immediate SIGTERM.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Trott · 2020-12-27T17:46:09Z

@benjamingr Is the behavior seen here as expected?

nodejs-github-bot · 2020-12-27T18:13:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35097/

benjamingr · 2020-12-27T18:16:38Z

github makes the PR very hard to read - but the behaviour seems correct yes :]

Trott · 2020-12-27T18:53:14Z

github makes the PR very hard to read - but the behaviour seems correct yes :]

Should be easier to read now that I've removed the lint errors. Whoops!

nodejs-github-bot · 2020-12-27T19:00:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35098/

benjamingr · 2020-12-27T20:38:29Z

What do you think about the behaviour? I think an AbortError might be nicer to users? Not sure

Trott · 2020-12-28T02:37:42Z

What do you think about the behaviour? I think an AbortError might be nicer to users? Not sure

That's what I was expecting, but I'm not familiar with the spec or general usage TBH.

benjamingr · 2020-12-28T08:57:30Z

That's what I was expecting, but I'm not familiar with the spec or general usage TBH.

I think that makes more sense yeah - want to fix the code to reject with that? Should be pretty straightforward.

(If you don't feel like it lmk and I'll make a separate PR or push another commit to this one whatever you prefer)

Trott · 2020-12-28T14:08:06Z

The other possible reasonable-seeming options are:

throw an error if the AbortController is already in an aborted state when execfile() is called
ignore an AbortController that is already in an aborted state when execfile() is called

Are we (you, I guess) sure those aren't better options?

benjamingr · 2020-12-28T14:11:46Z

throw an error if the AbortController is already in an aborted state when execfile() is called

That sounds like the preferable alternative to me.

Trott · 2020-12-28T14:58:43Z

throw an error if the AbortController is already in an aborted state when execfile() is called

That sounds like the preferable alternative to me.

Would it be appropriate to Do Whatever Fetch Does In That SItuation?

benjamingr · 2020-12-28T15:08:09Z

Would it be appropriate to Do Whatever Fetch Does In That SItuation?

const ac = new AbortController();
const { signal } = ac;
ac.abort();
fetch('./', { signal }).catch(() => {});
fetch('./', { signal }).catch(console.log); // Logs an AbortError

AbortError it is I think

Trott · 2020-12-29T00:54:40Z

AbortError it is I think

OK, done! Guess I better go and check the behavior of everything else that uses AbortController in child_process for consistency.

lib/child_process.js

Trott · 2020-12-29T02:30:47Z

OK, I think this is ready for review.

nodejs-github-bot · 2020-12-29T02:58:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35132/

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

If an AbortController passed to execfile() is already aborted, use the same behavior as if the controller was aborted after calling execfile(). This mimics the behavior of fetch in the browser. PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Move duplicate abort handler logic into a separate function. PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Trott · 2020-12-30T15:54:42Z

Landed in faee739...37acaf6

benjamingr · 2020-12-30T15:56:58Z

I didn't realize the GitHub labels automated Rich 😮

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

If an AbortController passed to execfile() is already aborted, use the same behavior as if the controller was aborted after calling execfile(). This mimics the behavior of fetch in the browser. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Move duplicate abort handler logic into a separate function. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

If an AbortController passed to execfile() is already aborted, use the same behavior as if the controller was aborted after calling execfile(). This mimics the behavior of fetch in the browser. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Move duplicate abort handler logic into a separate function. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

If an AbortController passed to execfile() is already aborted, use the same behavior as if the controller was aborted after calling execfile(). This mimics the behavior of fetch in the browser. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Move duplicate abort handler logic into a separate function. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

If an AbortController passed to execfile() is already aborted, use the same behavior as if the controller was aborted after calling execfile(). This mimics the behavior of fetch in the browser. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Move duplicate abort handler logic into a separate function. PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 27, 2020

Trott requested a review from benjamingr December 27, 2020 17:46

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2020

Trott force-pushed the reused-ac branch from 7bae84b to dbeca75 Compare December 27, 2020 18:52

Trott force-pushed the reused-ac branch from dbeca75 to 179d60a Compare December 29, 2020 00:55

Trott commented Dec 29, 2020

View reviewed changes

lib/child_process.js Outdated Show resolved Hide resolved

Trott added the child_process Issues and PRs related to the child_process subsystem. label Dec 29, 2020

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2020

benjamingr approved these changes Dec 29, 2020

View reviewed changes

watilde approved these changes Dec 30, 2020

View reviewed changes

benjamingr added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 30, 2020

Trott added 4 commits December 30, 2020 07:54

test: add test for reused AbortController with execfile()

6c0bd0b

Test that reusing an aborted AbortController with execfile() results in immediate SIGTERM. PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

child_process: reduce abort handler code duplication

36394b6

Move duplicate abort handler logic into a separate function. PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

test: add already-aborted-controller test for spawn()

37acaf6

PR-URL: nodejs#36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Trott force-pushed the reused-ac branch from c06b871 to 37acaf6 Compare December 30, 2020 15:54

Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020

Trott merged commit 37acaf6 into nodejs:master Dec 30, 2020

Trott deleted the reused-ac branch December 30, 2020 15:55

danielleadams pushed a commit that referenced this pull request Jan 12, 2021

test: add already-aborted-controller test for spawn()

f0dfe57

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

danielleadams mentioned this pull request Jan 12, 2021

v15.6.0 proposal #36889

Merged

targos pushed a commit that referenced this pull request May 25, 2021

test: add already-aborted-controller test for spawn()

eba43cc

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

targos pushed a commit that referenced this pull request Jun 5, 2021

test: add already-aborted-controller test for spawn()

0cbe63f

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

targos mentioned this pull request Jun 6, 2021

v14.17.1 release proposal #38948

Merged

targos pushed a commit that referenced this pull request Jun 11, 2021

test: add already-aborted-controller test for spawn()

3215a58

PR-URL: #36644 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add test for reused AbortController with execfile() #36644

test: add test for reused AbortController with execfile() #36644

Trott commented Dec 27, 2020

Trott commented Dec 27, 2020

nodejs-github-bot commented Dec 27, 2020

benjamingr commented Dec 27, 2020

Trott commented Dec 27, 2020

nodejs-github-bot commented Dec 27, 2020

benjamingr commented Dec 27, 2020

Trott commented Dec 28, 2020

benjamingr commented Dec 28, 2020

Trott commented Dec 28, 2020

benjamingr commented Dec 28, 2020

Trott commented Dec 28, 2020

benjamingr commented Dec 28, 2020

Trott commented Dec 29, 2020

Trott commented Dec 29, 2020

nodejs-github-bot commented Dec 29, 2020

Trott commented Dec 30, 2020

benjamingr commented Dec 30, 2020

test: add test for reused AbortController with execfile() #36644

test: add test for reused AbortController with execfile() #36644

Conversation

Trott commented Dec 27, 2020

Checklist

Trott commented Dec 27, 2020

nodejs-github-bot commented Dec 27, 2020

benjamingr commented Dec 27, 2020

Trott commented Dec 27, 2020

nodejs-github-bot commented Dec 27, 2020

benjamingr commented Dec 27, 2020

Trott commented Dec 28, 2020

benjamingr commented Dec 28, 2020

Trott commented Dec 28, 2020

benjamingr commented Dec 28, 2020

Trott commented Dec 28, 2020

benjamingr commented Dec 28, 2020

Trott commented Dec 29, 2020

Trott commented Dec 29, 2020

nodejs-github-bot commented Dec 29, 2020

Trott commented Dec 30, 2020

benjamingr commented Dec 30, 2020