Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix the exception description #3658

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/errors.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,9 @@ by other contexts.
<!--type=misc-->

A JavaScript "exception" is a value that is thrown as a result of an invalid operation or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The scare quotes around exception are unnecessary IMO. Since we're editing nearby text, maybe this is a good opportunity to remove them. Totally optional, feel free to ignore, I'm fine with the change as is.

as the target of a `throw` statement. While it is not required that these values inherit from
`Error`, all exceptions thrown by Node.js or the JavaScript runtime *will* be instances of Error.
as the target of a `throw` statement. While it is not required that these values are instances of
`Error` or classes which inherit from `Error`, all exceptions thrown by Node.js or the JavaScript
runtime *will* be instances of Error.

Some exceptions are *unrecoverable* at the JavaScript layer. These exceptions will always bring
down the process. These are usually failed `assert()` checks or `abort()` calls in the C++ layer.
Expand Down