Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix writable._construct() example #36509

Closed
wants to merge 1 commit into from
Closed

doc: fix writable._construct() example #36509

wants to merge 1 commit into from

Conversation

mkbaranovskyi
Copy link
Contributor

This is my first pull request, please correct me if I'm missing something. The proposed changes include two small bug fixes in the Stream reference, namely in the writable._construct() example:

  1. Incorrect property appointment in the constructor - no fd parameter is passed. Instead, this.fd is appointed in the _construct() method. Removing this line from the constructor() fixes the error.
  2. The fs.open() callback parameters switched places according to the fs.open reference (and my tests).
Checklist
  • [ x] documentation is changed or added

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Dec 14, 2020
@aduh95 aduh95 changed the title Two bugs in the writable._construct() ref example fixed doc,stream: fix writable._construct() example Dec 14, 2020
aduh95
aduh95 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this and sending a fix!

@mscdex mscdex changed the title doc,stream: fix writable._construct() example doc: fix writable._construct() example Dec 14, 2020
Trott pushed a commit that referenced this pull request Dec 25, 2020
@mkbaranovskyi @Trott
doc: fix bugs in _construct() example
f441c8b 
PR-URL: #36509
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 25, 2020

Landed in f441c8b.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 25, 2020
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@mkbaranovskyi @danielleadams
doc: fix bugs in _construct() example
3ee4cfc 
PR-URL: #36509
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@ronag ronag ronag approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mkbaranovskyi @Trott @jasnell @lpinca @ronag @aduh95 @targos @nodejs-github-bot