Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: forward new SecureContext options #36416

Closed
wants to merge 1 commit into from

Commits on Dec 7, 2020

  1. tls: forward new SecureContext options

    We have a few places where we individually forward each
    parameter to tls.createSecureContext(). In nodejs#28973 and others,
    we added new SecureContext options but forgot to keep these
    places up to date.
    
    As per https.Agent#getName, I understand that at least
    `privateKeyIdentifier` and `privateKeyEngine` should be
    added too, since they're a substitute for `key`. I've
    also added sigalgs.
    
    Fixes: nodejs#36322
    Refs: nodejs#28973
    mildsunrise committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    3c353b6 View commit details
    Browse the repository at this point in the history