tools: update doc tool dependencies #36407

targos · 2020-12-06T13:22:26Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2020-12-06T15:49:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34795/

Trott · 2020-12-07T15:35:01Z

tools/doc/package.json

    "rehype-stringify": "8.0.0",
    "remark-gfm": "^1.0.0",
-    "remark-html": "12.0.0",
+    "remark-html": "13.0.1",


I know these are listed as dev dependencies in the package.json, but they are used to generate our docs so a breaking change especially requires caution. When I do something like this, I make the docs with the packages in master and then make them with the packages in my branch and diff them.

(I'm doing this right now and will report what I find.)

Quick review shows lots of changes to code block rendering, but a spot check shows them to be either improvements or something that doesn't change anything I can detect visually. Here's the list of changes. If anyone's curious about any of them but doesn't want to build the docs themselves, I can post screenshots. (Building the docs is super easy and fast, though.)

diff -r out/doc/api/all.html out/doc-old/api/all.html 4936c4936 --- 5323c5323 < assert.deepStrictEqual(-0, -0); --- > assert.deepStrictEqual(-0, -0); 5327c5327 < assert.deepStrictEqual(0, -0); --- > assert.deepStrictEqual(0, -0); 6308,6309c6308,6309 < init(asyncId, type, triggerAsyncId, resource) { }, < destroy(asyncId) { } --- > init(asyncId, type, triggerAsyncId, resource) { }, > destroy(asyncId) { } 6313,6314c6313,6314 < init(asyncId, type, triggerAsyncId, resource) { } < destroy(asyncId) {} --- > init(asyncId, type, triggerAsyncId, resource) { } > destroy(asyncId) {} 6318,6319c6318,6319 < before(asyncId) { } < after(asyncId) { } --- > before(asyncId) { } > after(asyncId) { } 6426c6426 < init(asyncId, type, triggerAsyncId) { --- > init(asyncId, type, triggerAsyncId) { 6464c6464 < init(asyncId, type, triggerAsyncId) { --- > init(asyncId, type, triggerAsyncId) { 6472c6472 < before(asyncId) { --- > before(asyncId) { 6477c6477 < after(asyncId) { --- > after(asyncId) { 6482c6482 < destroy(asyncId) { --- > destroy(asyncId) { 6622c6622 < init(asyncId, type, triggerAsyncId, resource) { --- > init(asyncId, type, triggerAsyncId, resource) { 6709c6709 < ah.createHook({ init() {} }).enable(); // forces PromiseHooks to be enabled. --- > ah.createHook({ init() {} }).enable(); // forces PromiseHooks to be enabled. 6780c6780 < constructor(db) { --- > constructor(db) { 6785c6785 < getInfo(query, callback) { --- > getInfo(query, callback) { 6791c6791 < close() { --- > close() { 6870c6870 < constructor(callback) { --- > constructor(callback) { 6875c6875 < done(err, result) { --- > done(err, result) { 6882c6882 < constructor(numThreads) { --- > constructor(numThreads) { 6892c6892 < addNewWorker() { --- > addNewWorker() { 6920c6920 < runTask(task, callback) { --- > runTask(task, callback) { 6932c6932 < close() { --- > close() { 7190c7190 < const buf5 = Buffer.from([257, 257.5, -255, '1']); --- > const buf5 = Buffer.from([257, 257.5, -255, '1']); 8201c8201 < console.log(utf16Buffer.indexOf('\u03a3', -4, 'utf16le')); --- > console.log(utf16Buffer.indexOf('\u03a3', -4, 'utf16le')); 8291c8291 < console.log(utf16Buffer.lastIndexOf('\u03a3', -5, 'utf16le')); --- > console.log(utf16Buffer.lastIndexOf('\u03a3', -5, 'utf16le')); 8523c8523 < <pre><code class="language-js">const buf = Buffer.from([-1, 5]); --- > <pre><code class="language-js">const buf = Buffer.from([-1, 5]); 8705c8705 < <pre><code class="language-js">const buf = Buffer.from([1, -2]); --- > <pre><code class="language-js">const buf = Buffer.from([1, -2]); 8919c8919 < console.log(buf.subarray(-6, -1).toString()); --- > console.log(buf.subarray(-6, -1).toString()); 8923c8923 < console.log(buf.subarray(-6, -2).toString()); --- > console.log(buf.subarray(-6, -2).toString()); 8927c8927 < console.log(buf.subarray(-5, -2).toString()); --- > console.log(buf.subarray(-5, -2).toString()); 9382c9382 < buf.writeInt8(-2, 1); --- > buf.writeInt8(-2, 1); 11666c11666 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 11744c11744 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 11756c11756 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 12729c12729 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 12743c12743 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 12757c12757 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 12765c12765 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 12785c12785 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 14159c14159 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 28400c28400 < <pre><code class="language-js">require('net').connect(-1); --- > <pre><code class="language-js">require('net').connect(-1); 30653c30653 < constructor() { --- > constructor() { 30662c30662 < destroy(err) { --- > destroy(err) { 31055c31055 < handleEvent(event) { --- > handleEvent(event) { 31061c31061 < async handleEvent(event) { --- > async handleEvent(event) { 31518c31518 < (async function(from, to) { --- > (async function(from, to) { 41906c41906 < is 0. The maximum allowed value is 2232-1. A negative value sets --- > is 0. The maximum allowed value is 232-1. A negative value sets 42171c42171 < is 2232-1. Default: <code>4096</code>.</li> --- > is 232-1. Default: <code>4096</code>.</li> 42179c42179 < 2224-1. Default: <code>16384</code>.</li> --- > 224-1. Default: <code>16384</code>.</li> 42188c42188 < maximum allowed value is 2232-1. Default: <code>65535</code>.</li> --- > maximum allowed value is 232-1. Default: <code>65535</code>.</li> 43916c43916 < constructor(width) { --- > constructor(width) { 43920c43920 < area() { --- > area() { 44257c44257 < <pre><code class="language-js">(function(exports, require, module, __filename, __dirname) { --- > <pre><code class="language-js">(function(exports, require, module, __filename, __dirname) { 44539c44539 < <pre><code class="language-js">function require(/* ... */) { --- > <pre><code class="language-js">function require(/* ... */) { 50339c50339 < init(id, type) { --- > init(id, type) { 50345c50345 < destroy(id) { --- > destroy(id) { 55290c55290 < async clientHelloHandler(alpn, servername, ciphers) { --- > async clientHelloHandler(alpn, servername, ciphers) { 56403c56403 < action(name) { --- > action(name) { 57197c57197 --- 58760c58760 < constructor({ highWaterMark, ...options }) { --- > constructor({ highWaterMark, ...options }) { 58825c58825 < construct(callback) { --- > construct(callback) { 58828c58828 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 58831c58831 < destroy() { --- > destroy() { 58895c58895 < constructor(options) { --- > constructor(options) { 58915c58915 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 58918c58918 < writev(chunks, callback) { --- > writev(chunks, callback) { 58941c58941 < constructor(filename) { --- > constructor(filename) { 58946c58946 < _construct(callback) { --- > _construct(callback) { 58956c58956 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 58959c58959 < _destroy(err, callback) { --- > _destroy(err, callback) { 59070c59070 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 59086c59086 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 59103c59103 < constructor(options) { --- > constructor(options) { 59108c59108 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 59115c59115 < _final(callback) { --- > _final(callback) { 59173c59173 < constructor(options) { --- > constructor(options) { 59193c59193 < read(size) { --- > read(size) { 59216c59216 < constructor(filename) { --- > constructor(filename) { 59221c59221 < _construct(callback) { --- > _construct(callback) { 59231c59231 < _read(n) { --- > _read(n) { 59241c59241 < _destroy(err, callback) { --- > _destroy(err, callback) { 59329c59329 < constructor(options) { --- > constructor(options) { 59348c59348 < _read(size) { --- > _read(size) { 59365c59365 < read(size) { --- > read(size) { 59381c59381 < constructor(opt) { --- > constructor(opt) { 59387c59387 < _read() { --- > _read() { 59447c59447 < constructor(options) { --- > constructor(options) { 59466c59466 < read(size) { --- > read(size) { 59469c59469 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 59482c59482 < construct(callback) { --- > construct(callback) { 59486c59486 < transform(chunk, encoding, callback) { --- > transform(chunk, encoding, callback) { 59490c59490 < flush(callback) { --- > flush(callback) { 59521c59521 < constructor(source, options) { --- > constructor(source, options) { 59526c59526 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 59534c59534 < _read(size) { --- > _read(size) { 59557c59557 < transform(chunk, encoding, callback) { --- > transform(chunk, encoding, callback) { 59612c59612 < constructor(options) { --- > constructor(options) { 59631c59631 < transform(chunk, encoding, callback) { --- > transform(chunk, encoding, callback) { 64529c64529 < write(data) { --- > write(data) { 64863c64863 < constructor(value) { --- > constructor(value) { 64921c64921 < constructor(value) { --- > constructor(value) { 64925c64925 < toString() { --- > toString() { 65008c65008 < constructor() { --- > constructor() { 65012c65012 < bar(callback) { --- > bar(callback) { 67406c67406 < initializeImportMeta(meta) { --- > initializeImportMeta(meta) { diff -r out/doc/api/assert.html out/doc-old/api/assert.html 251c251 --- 638c638 < assert.deepStrictEqual(-0, -0); --- > assert.deepStrictEqual(-0, -0); 642c642 < assert.deepStrictEqual(0, -0); --- > assert.deepStrictEqual(0, -0); diff -r out/doc/api/async_hooks.html out/doc-old/api/async_hooks.html 295,296c295,296 < init(asyncId, type, triggerAsyncId, resource) { }, < destroy(asyncId) { } --- > init(asyncId, type, triggerAsyncId, resource) { }, > destroy(asyncId) { } 300,301c300,301 < init(asyncId, type, triggerAsyncId, resource) { } < destroy(asyncId) {} --- > init(asyncId, type, triggerAsyncId, resource) { } > destroy(asyncId) {} 305,306c305,306 < before(asyncId) { } < after(asyncId) { } --- > before(asyncId) { } > after(asyncId) { } 413c413 < init(asyncId, type, triggerAsyncId) { --- > init(asyncId, type, triggerAsyncId) { 451c451 < init(asyncId, type, triggerAsyncId) { --- > init(asyncId, type, triggerAsyncId) { 459c459 < before(asyncId) { --- > before(asyncId) { 464c464 < after(asyncId) { --- > after(asyncId) { 469c469 < destroy(asyncId) { --- > destroy(asyncId) { 609c609 < init(asyncId, type, triggerAsyncId, resource) { --- > init(asyncId, type, triggerAsyncId, resource) { 696c696 < ah.createHook({ init() {} }).enable(); // forces PromiseHooks to be enabled. --- > ah.createHook({ init() {} }).enable(); // forces PromiseHooks to be enabled. 767c767 < constructor(db) { --- > constructor(db) { 772c772 < getInfo(query, callback) { --- > getInfo(query, callback) { 778c778 < close() { --- > close() { 857c857 < constructor(callback) { --- > constructor(callback) { 862c862 < done(err, result) { --- > done(err, result) { 869c869 < constructor(numThreads) { --- > constructor(numThreads) { 879c879 < addNewWorker() { --- > addNewWorker() { 907c907 < runTask(task, callback) { --- > runTask(task, callback) { 919c919 < close() { --- > close() { diff -r out/doc/api/buffer.html out/doc-old/api/buffer.html 287c287 < const buf5 = Buffer.from([257, 257.5, -255, '1']); --- > const buf5 = Buffer.from([257, 257.5, -255, '1']); 1298c1298 < console.log(utf16Buffer.indexOf('\u03a3', -4, 'utf16le')); --- > console.log(utf16Buffer.indexOf('\u03a3', -4, 'utf16le')); 1388c1388 < console.log(utf16Buffer.lastIndexOf('\u03a3', -5, 'utf16le')); --- > console.log(utf16Buffer.lastIndexOf('\u03a3', -5, 'utf16le')); 1620c1620 < <pre><code class="language-js">const buf = Buffer.from([-1, 5]); --- > <pre><code class="language-js">const buf = Buffer.from([-1, 5]); 1802c1802 < <pre><code class="language-js">const buf = Buffer.from([1, -2]); --- > <pre><code class="language-js">const buf = Buffer.from([1, -2]); 2016c2016 < console.log(buf.subarray(-6, -1).toString()); --- > console.log(buf.subarray(-6, -1).toString()); 2020c2020 < console.log(buf.subarray(-6, -2).toString()); --- > console.log(buf.subarray(-6, -2).toString()); 2024c2024 < console.log(buf.subarray(-5, -2).toString()); --- > console.log(buf.subarray(-5, -2).toString()); 2479c2479 < buf.writeInt8(-2, 1); --- > buf.writeInt8(-2, 1); diff -r out/doc/api/errors.html out/doc-old/api/errors.html 805c805 < <pre><code class="language-js">require('net').connect(-1); --- > <pre><code class="language-js">require('net').connect(-1); diff -r out/doc/api/events.html out/doc-old/api/events.html 823c823 < constructor() { --- > constructor() { 832c832 < destroy(err) { --- > destroy(err) { 1225c1225 < handleEvent(event) { --- > handleEvent(event) { 1231c1231 < async handleEvent(event) { --- > async handleEvent(event) { diff -r out/doc/api/fs.html out/doc-old/api/fs.html 496c496 < (async function(from, to) { --- > (async function(from, to) { diff -r out/doc/api/http2.html out/doc-old/api/http2.html 2484c2484 < is 0. The maximum allowed value is 2232-1. A negative value sets --- > is 0. The maximum allowed value is 232-1. A negative value sets 2749c2749 < is 2232-1. Default: <code>4096</code>.</li> --- > is 232-1. Default: <code>4096</code>.</li> 2757c2757 < 2224-1. Default: <code>16384</code>.</li> --- > 224-1. Default: <code>16384</code>.</li> 2766c2766 < maximum allowed value is 2232-1. Default: <code>65535</code>.</li> --- > maximum allowed value is 232-1. Default: <code>65535</code>.</li> diff -r out/doc/api/modules.html out/doc-old/api/modules.html 226c226 < constructor(width) { --- > constructor(width) { 230c230 < area() { --- > area() { 567c567 < <pre><code class="language-js">(function(exports, require, module, __filename, __dirname) { --- > <pre><code class="language-js">(function(exports, require, module, __filename, __dirname) { 849c849 < <pre><code class="language-js">function require(/* ... */) { --- > <pre><code class="language-js">function require(/* ... */) { diff -r out/doc/api/n-api.html out/doc-old/api/n-api.html 874c874 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 952c952 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 964c964 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 1937c1937 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 1951c1951 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 1965c1965 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 1973c1973 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 1993c1993 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { 3367c3367 < <pre><code class="language-c">typedef enum { --- > <pre><code class="language-c">typedef enum { diff -r out/doc/api/perf_hooks.html out/doc-old/api/perf_hooks.html 825c825 < init(id, type) { --- > init(id, type) { 831c831 < destroy(id) { --- > destroy(id) { diff -r out/doc/api/quic.html out/doc-old/api/quic.html 2581c2581 < async clientHelloHandler(alpn, servername, ciphers) { --- > async clientHelloHandler(alpn, servername, ciphers) { diff -r out/doc/api/repl.html out/doc-old/api/repl.html 540c540 < action(name) { --- > action(name) { diff -r out/doc/api/stream.html out/doc-old/api/stream.html 293c293 --- 1856c1856 < constructor({ highWaterMark, ...options }) { --- > constructor({ highWaterMark, ...options }) { 1921c1921 < construct(callback) { --- > construct(callback) { 1924c1924 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 1927c1927 < destroy() { --- > destroy() { 1991c1991 < constructor(options) { --- > constructor(options) { 2011c2011 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 2014c2014 < writev(chunks, callback) { --- > writev(chunks, callback) { 2037c2037 < constructor(filename) { --- > constructor(filename) { 2042c2042 < _construct(callback) { --- > _construct(callback) { 2052c2052 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 2055c2055 < _destroy(err, callback) { --- > _destroy(err, callback) { 2166c2166 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 2182c2182 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 2199c2199 < constructor(options) { --- > constructor(options) { 2204c2204 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 2211c2211 < _final(callback) { --- > _final(callback) { 2269c2269 < constructor(options) { --- > constructor(options) { 2289c2289 < read(size) { --- > read(size) { 2312c2312 < constructor(filename) { --- > constructor(filename) { 2317c2317 < _construct(callback) { --- > _construct(callback) { 2327c2327 < _read(n) { --- > _read(n) { 2337c2337 < _destroy(err, callback) { --- > _destroy(err, callback) { 2425c2425 < constructor(options) { --- > constructor(options) { 2444c2444 < _read(size) { --- > _read(size) { 2461c2461 < read(size) { --- > read(size) { 2477c2477 < constructor(opt) { --- > constructor(opt) { 2483c2483 < _read() { --- > _read() { 2543c2543 < constructor(options) { --- > constructor(options) { 2562c2562 < read(size) { --- > read(size) { 2565c2565 < write(chunk, encoding, callback) { --- > write(chunk, encoding, callback) { 2578c2578 < construct(callback) { --- > construct(callback) { 2582c2582 < transform(chunk, encoding, callback) { --- > transform(chunk, encoding, callback) { 2586c2586 < flush(callback) { --- > flush(callback) { 2617c2617 < constructor(source, options) { --- > constructor(source, options) { 2622c2622 < _write(chunk, encoding, callback) { --- > _write(chunk, encoding, callback) { 2630c2630 < _read(size) { --- > _read(size) { 2653c2653 < transform(chunk, encoding, callback) { --- > transform(chunk, encoding, callback) { 2708c2708 < constructor(options) { --- > constructor(options) { 2727c2727 < transform(chunk, encoding, callback) { --- > transform(chunk, encoding, callback) { diff -r out/doc/api/util.html out/doc-old/api/util.html 594c594 < write(data) { --- > write(data) { 928c928 < constructor(value) { --- > constructor(value) { 986c986 < constructor(value) { --- > constructor(value) { 990c990 < toString() { --- > toString() { 1073c1073 < constructor() { --- > constructor() { 1077c1077 < bar(callback) { --- > bar(callback) { diff -r out/doc/api/vm.html out/doc-old/api/vm.html 843c843 < initializeImportMeta(meta) { --- > initializeImportMeta(meta) { diff -r out/doc/apilinks.json out/doc-old/apilinks.json 2,519c2,519 ---

Sample improvement: The assert docs now highlight -0 as a number instead of highlighting only 0 and leaving the - un-highlighted:

Before:

After:

Sample "I don't see any difference despite the underlying code changing": The vm module has this line changed but I don't see any difference.

Before:

After:

(Alignment change is due to the imprecision of my screenshot placement. They are identical.)

targos · 2020-12-07T16:30:08Z

Thanks for double checking @Trott . I should have been more transparent and said that I did exactly what you did

nodejs-github-bot · 2020-12-07T19:54:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34830/

MylesBorins

LGTM

nodejs-github-bot · 2020-12-08T20:37:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34860/

github-actions · 2020-12-08T22:18:03Z

Landed in e31a99f...8dbeac6

PR-URL: #36407 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Dec 6, 2020

targos mentioned this pull request Dec 6, 2020

build(deps-dev): bump highlight.js from 10.1.2 to 10.4.1 in /tools/doc #36390

Closed

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020

Trott reviewed Dec 7, 2020

View reviewed changes

Trott approved these changes Dec 7, 2020

View reviewed changes

tools: update doc tool dependencies

55d5e66

targos force-pushed the update-docs branch from 91ecd7a to 55d5e66 Compare December 7, 2020 19:47

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020

MylesBorins approved these changes Dec 8, 2020

View reviewed changes

jasnell approved these changes Dec 8, 2020

View reviewed changes

MylesBorins added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions bot closed this Dec 8, 2020

nodejs-github-bot pushed a commit that referenced this pull request Dec 8, 2020

tools: update doc tool dependencies

8dbeac6

PR-URL: #36407 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>

targos deleted the update-docs branch December 8, 2020 22:20

targos added a commit that referenced this pull request Dec 21, 2020

tools: update doc tool dependencies

8ecf2f9

PR-URL: #36407 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request Dec 22, 2020

v15.5.0 release proposal #36597

Merged

targos added a commit that referenced this pull request May 1, 2021

tools: update doc tool dependencies

7ac8ab8

PR-URL: #36407 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

kvakil mentioned this pull request Jul 16, 2022

doc: repeated text when using superscripts #43864

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: update doc tool dependencies #36407

tools: update doc tool dependencies #36407

targos commented Dec 6, 2020

nodejs-github-bot commented Dec 6, 2020

Trott Dec 7, 2020

Trott Dec 7, 2020

Trott Dec 7, 2020 •

edited

Loading

Trott Dec 7, 2020 •

edited

Loading

Trott Dec 7, 2020 •

edited

Loading

targos commented Dec 7, 2020

nodejs-github-bot commented Dec 7, 2020

MylesBorins left a comment

nodejs-github-bot commented Dec 8, 2020

github-actions bot commented Dec 8, 2020

tools: update doc tool dependencies #36407

tools: update doc tool dependencies #36407

Conversation

targos commented Dec 6, 2020

Checklist

nodejs-github-bot commented Dec 6, 2020

Trott Dec 7, 2020

Choose a reason for hiding this comment

Trott Dec 7, 2020

Choose a reason for hiding this comment

Trott Dec 7, 2020 • edited Loading

Choose a reason for hiding this comment

Trott Dec 7, 2020 • edited Loading

Choose a reason for hiding this comment

Trott Dec 7, 2020 • edited Loading

Choose a reason for hiding this comment

targos commented Dec 7, 2020

nodejs-github-bot commented Dec 7, 2020

MylesBorins left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 8, 2020

github-actions bot commented Dec 8, 2020

Trott Dec 7, 2020 •

edited

Loading

Trott Dec 7, 2020 •

edited

Loading

Trott Dec 7, 2020 •

edited

Loading