Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update stability index linking logic #36280

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 26, 2020

Fix logic that prevents stability index text from linking to itself.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 26, 2020
@Trott
Copy link
Member Author

Trott commented Nov 26, 2020

Before:
image

After:
image

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Fix logic that prevents stability index text from linking to itself.

PR-URL: nodejs#36280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 1, 2020

Landed in cb023a3

@Trott Trott merged commit cb023a3 into nodejs:master Dec 1, 2020
@Trott Trott deleted the stability-link branch December 1, 2020 00:58
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
Fix logic that prevents stability index text from linking to itself.

PR-URL: #36280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
Fix logic that prevents stability index text from linking to itself.

PR-URL: nodejs#36280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
Fix logic that prevents stability index text from linking to itself.

PR-URL: #36280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants