Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added a License #36278

Merged
merged 1 commit into from
Dec 15, 2020
Merged

docs: added a License #36278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ The Node.js project uses an [open governance model](./GOVERNANCE.md). The
* [TSC (Technical Steering Committee)](#tsc-technical-steering-committee)
* [Collaborators](#collaborators)
* [Release Keys](#release-keys)
* [License](#license)

## Support

Expand Down Expand Up @@ -645,6 +646,14 @@ Other keys used to sign some previous releases:
* **Timothy J Fontaine** <[email protected]>
`7937DFD2AB06298B2293C3187D33FF9D0246406D`

## License

Node.js is available under the
[MIT license](https://opensource.org/licenses/MIT). Node.js also includes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to the LICENSE file instead.

Copy link
Contributor

@aduh95 aduh95 Nov 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license file is linked just below, are you suggesting to also remove the See LICENSE for the full license text sentence?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @jasnell I think this is the last thing we need to clarify before this can land.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removing the last sentence and moving the link to the LICENSE file should work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell sorry I missed your comment before landing, do you want me to revert?

external libraries that are available under a variety of licenses. See
[LICENSE](https://github.com/nodejs/node/blob/master/LICENSE) for the full
license text.

[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
[Contributing to the project]: CONTRIBUTING.md
[Node.js Website]: https://nodejs.org/
Expand Down