Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix undeclared identifier FALSE #36276

Merged
merged 1 commit into from
Nov 28, 2020
Merged

tools: fix undeclared identifier FALSE #36276

merged 1 commit into from
Nov 28, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 26, 2020

I'm getting an error when trying to compile master with small ICU:

../tools/icu/iculslocs.cc:153:13: error: use of undeclared identifier 'FALSE'
  *exists = FALSE;
            ^
1 error generated.

The rest of the file is using false instead of FALSE, this seems to be an error so here's the fix.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 26, 2020
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 26, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34577/ ✅

@aduh95 @Trott
tools: fix undeclared identifier FALSE
2999845 
PR-URL: nodejs#36276
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott merged commit 2999845 into nodejs:master Nov 28, 2020
@Trott
Copy link
Member

Trott commented Nov 28, 2020

Landed in 2999845

@aduh95 aduh95 deleted the fix-undeclared-false branch November 28, 2020 14:54
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
tools: fix undeclared identifier FALSE
5935ccc 
PR-URL: #36276
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
tools: fix undeclared identifier FALSE
17f942f 
PR-URL: #36276
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
This was referenced Aug 16, 2022
Open
Open
@Dmarch28 Dmarch28 mentioned this pull request Aug 16, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Aug 16, 2022
Open
@kissofire kissofire mentioned this pull request Aug 16, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Aug 17, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2022
Open
@baby636 baby636 mentioned this pull request Aug 17, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Aug 17, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @Trott @lpinca @targos @richardlau