Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use using-declaration consistently #36245

Closed
wants to merge 2 commits into from
Closed

tools: use using-declaration consistently #36245

wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 24, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 24, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34531/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34533/

@danbev
Copy link
Contributor Author

danbev commented Nov 25, 2020

Re-run of failing node-test-commit-linux-containered ✔️

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2020
danbev added a commit that referenced this pull request Nov 27, 2020
@danbev
tools: use using-declaration consistently
0a23d65 
PR-URL: #36245
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Nov 27, 2020

Landed in 0a23d65.

@danbev danbev closed this Nov 27, 2020
@danbev danbev deleted the snapshot_builder_using branch November 27, 2020 04:55
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@danbev @danielleadams
tools: use using-declaration consistently
a2da7ba 
PR-URL: #36245
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @nodejs-github-bot @jasnell @lpinca @cjihrig @richardlau @gireeshpunathil @targos