fs: pass the error if directory already closed

[Lxxyx]

Asynchronous functions should forward errors via callback.
In the case of Promise, errors can be caught with Promise.catch

Fixes: #36237

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[Lxxyx]

Thanks for the guide, the code has been updated. @targos @aduh95

[Lxxyx]

Thanks for the Review, changes have been pushed. @aduh95

[aduh95]

On a second thought, I think the tests could be improved a bit:

[Lxxyx]

Thanks, learned a lot about how to test Node.js. The code has been updated @aduh95

[joyeecheung]

Still LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34556/ ✅

[github-actions]

Commit Queue failed

- Loading data for nodejs/node/pull/36243
✔  Done loading data for nodejs/node/pull/36243
----------------------------------- PR info ------------------------------------
Title      fs/dir: pass the error to the callback or Promise.catch if already closed (#36243)
Author     Lxxyx  (@Lxxyx, first-time contributor)
Branch     Lxxyx:fix/dir-close-throws -> nodejs:master
Labels     author ready, fs
Commits    1
 - fs/dir: pass the error to the callback or Promise.catch if already cl…
Committers 1
 - Zijian Liu 
PR-URL: https://github.com/nodejs/node/pull/36243
Fixes: https://github.com/nodejs/node/issues/36237
Reviewed-By: Antoine du Hamel 
Reviewed-By: Joyee Cheung 
Reviewed-By: Rich Trott 
Reviewed-By: Yongsheng Zhang 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36243
Fixes: https://github.com/nodejs/node/issues/36237
Reviewed-By: Antoine du Hamel 
Reviewed-By: Joyee Cheung 
Reviewed-By: Rich Trott 
Reviewed-By: Yongsheng Zhang 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-25T15:23:50Z: https://ci.nodejs.org/job/node-test-pull-request/34556/
- Querying data for job/node-test-pull-request/34556/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Tue, 24 Nov 2020 06:32:49 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36243#pullrequestreview-538317002
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/36243#pullrequestreview-538603019
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36243#pullrequestreview-539312063
   ✔  - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/36243#pullrequestreview-539441282
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 36243
From https://github.com/nodejs/node
 * branch                  refs/pull/36243/merge -> FETCH_HEAD
✔  Fetched commits as b4c2ff5a3bb5..1fb210c50356
--------------------------------------------------------------------------------
[master 7e448d0bca] fs/dir: pass the error to the callback or Promise.catch if already closed
 Author: Zijian Liu 
 Date: Tue Nov 24 14:30:26 2020 +0800
 2 files changed, 32 insertions(+), 8 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
   ⚠  Found Fixes: https://github.com/nodejs/node/issues/36237, skipping..
--------------------------------- New Message ----------------------------------
fs/dir: pass the error to the callback or Promise.catch if already closed
Asynchronous functions should forward errors via callback.

In the case of Promise, errors can be caught with Promise.catch
Fixes: #36237
PR-URL: #36243

Reviewed-By: Antoine du Hamel [email protected]

Reviewed-By: Joyee Cheung [email protected]

Reviewed-By: Rich Trott [email protected]

Reviewed-By: Yongsheng Zhang [email protected]
[master d662e3e511] fs/dir: pass the error to the callback or Promise.catch if already closed

Author: Zijian Liu [email protected]

Date: Tue Nov 24 14:30:26 2020 +0800

2 files changed, 32 insertions(+), 8 deletions(-)

✖  d662e3e51170c112b172f51bc028412b83a71ed7

✔  4:7      Valid fixes URL.                          fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  6:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Invalid subsystem: "fs/dir"               subsystem

✔  0:0      Title is formatted correctly.             title-format

✖  0:72     Title must be <= 72 columns.              title-length

ℹ  Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/387516680

[Lxxyx]

Tried to update the name of Pull Request to avoid "Commit Queue failed" error. @aduh95

[aduh95]

Landed in b938f88