Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: missed warning for non-experimental AbortController #36240

Merged
merged 1 commit into from
Nov 24, 2020
Merged

test: missed warning for non-experimental AbortController #36240

merged 1 commit into from
Nov 24, 2020

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 23, 2020

Test was missed when landing PR (change landed after the CI had run). Should fast-track this.

Signed-off-by: James M Snell [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 23, 2020
@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34523/

@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2020

👍 to fast-track

mhdawson
mhdawson approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Nov 23, 2020

Just waiting on CI to finish to land.

@Trott
Copy link
Member

Trott commented Nov 24, 2020

change landed after the CI had run

node-core-utils warns about that. If it didn't warn about that, maybe update to the newest version?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34525/

@jasnell @Trott
test: fix missed warning for non-experimental AbortController
4388c14 
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#36240
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott merged commit 4388c14 into nodejs:master Nov 24, 2020
@Trott
Copy link
Member

Trott commented Nov 24, 2020

Landed in 4388c14

danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@jasnell @danielleadams
test: fix missed warning for non-experimental AbortController
44d6d0b 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36240
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@codebytere codebytere codebytere approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @aduh95 @Trott @codebytere @mhdawson @targos