Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark : changed fstat to fstatSync #36206

Closed
wants to merge 1 commit into from
Closed

benchmark : changed fstat to fstatSync #36206

wants to merge 1 commit into from

Conversation

Narasimha1997
Copy link
Contributor

@Narasimha1997 Narasimha1997 commented Nov 21, 2020 •
edited by aduh95
Loading

Changed fstat to fstatSync as mentioned in the issue #36199

Fixes: #36199

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Nov 21, 2020
@aduh95 aduh95 requested a review from mscdex November 21, 2020 12:56
@gireeshpunathil gireeshpunathil mentioned this pull request Nov 23, 2020
Closed
2 tasks
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34555/ ✅

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2020
@gireeshpunathil gireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2020
@github-actions
Copy link
Contributor

Landed in 2b21a31...49abda7

@github-actions github-actions bot closed this Nov 26, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 26, 2020
@Narasimha1997 @nodejs-github-bot
benchmark : changed fstat to fstatSync
49abda7 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gireeshpunathil
Copy link
Member

thanks @Narasimha1997 for the contribution! 🎉

@Narasimha1997
Copy link
Contributor Author

@gireeshpunathil ,
Thank you so much. Looking forword to contribute and learn more in the coming days.

danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Narasimha1997 @danielleadams
benchmark : changed fstat to fstatSync
2344e3e 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Narasimha1997 @targos
benchmark : changed fstat to fstatSync
2bbf253 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@mscdex mscdex Awaiting requested review from mscdex

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

benchmark: dead code
7 participants
@Narasimha1997 @nodejs-github-bot @gireeshpunathil @jasnell @Trott @lpinca @aduh95