-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: refactor to use more primordials #36166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR seems to be causing some noticeable regressions across multiple benchmark runs for fill()
as seen in these benchmark results for example:
buffers/buffer-fill.js n=20000 size=8192 type='fill(0)' *** -31.61 % ±5.72% ±7.65% ±10.04%
buffers/buffer-fill.js n=20000 size=8192 type='fill(100)' *** -31.92 % ±3.21% ±4.28% ±5.59%
buffers/buffer-fill.js n=20000 size=8192 type='fill(400)' *** -32.13 % ±4.27% ±5.69% ±7.43%
buffers/buffer-fill.js n=20000 size=8192 type='fill("t", 0, "utf8")' *** -9.67 % ±5.14% ±6.84% ±8.90%
buffers/buffer-fill.js n=20000 size=8192 type='fill("t", "utf8")' *** -11.96 % ±5.80% ±7.71% ±10.05%
I've removed the use of
EDIT: I wasn't comparing to master! The above table shows the comparison between master (cde87ed) and this PR on top of #36221. |
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/707/ (queued, will 404 until it starts) |
The benchmark results are here:
@mscdex Do you think it's good enough? |
Commit Queue failed- Loading data for nodejs/node/pull/36166 ✔ Done loading data for nodejs/node/pull/36166 ----------------------------------- PR info ------------------------------------ Title buffer: refactor to use more primordials (#36166) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:buffer-primordials -> nodejs:master Labels buffer Commits 3 - buffer: refactor to use more primordials - fixup! buffer: refactor to use more primordials - fixup! buffer: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36166 Reviewed-By: James M Snell Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36166 Reviewed-By: James M Snell Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No full Jenkins CI runs detected ℹ Last Benchmark CI on 2020-11-25T13:26:09Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/707/ - Querying data for job/node-test-pull-request/707/ ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 18 Nov 2020 19:03:38 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36166#pullrequestreview-538673026 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36166#pullrequestreview-540005623 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/394030334 |
This comment has been minimized.
This comment has been minimized.
PR-URL: nodejs#36166 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
dd068f4
to
7d45dd9
Compare
Landed in 7d45dd9 |
PR-URL: #36166 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#36166 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36166 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36166 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes