doc: clarify text about process not responding #36117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Nov 15, 2020
aduh95
approved these changes
Nov 17, 2020
|
Landed in 8938d37 |
Trott
force-pushed
the
stop-responding
branch
from
fc6c364
to
8938d37
Compare
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
The existing text about processes not responding is unclear, at least to me. Suggestions for clarification welcome, but I think the best thing might be to state that the process may stop responding and leave it at that. The explanantion (about asynchronous listeners) is not clear to me. (Why would the fact that the listeners are asynchronous matter?) If it's an unnecessary detail (as seems likely), let's remove it. PR-URL: #36117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
The existing text about processes not responding is unclear, at least to me. Suggestions for clarification welcome, but I think the best thing might be to state that the process may stop responding and leave it at that. The explanantion (about asynchronous listeners) is not clear to me. (Why would the fact that the listeners are asynchronous matter?) If it's an unnecessary detail (as seems likely), let's remove it. PR-URL: #36117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
The existing text about processes not responding is unclear, at least to me. Suggestions for clarification welcome, but I think the best thing might be to state that the process may stop responding and leave it at that. The explanantion (about asynchronous listeners) is not clear to me. (Why would the fact that the listeners are asynchronous matter?) If it's an unnecessary detail (as seems likely), let's remove it. PR-URL: #36117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
The existing text about processes not responding is unclear, at least to me. Suggestions for clarification welcome, but I think the best thing might be to state that the process may stop responding and leave it at that. The explanantion (about asynchronous listeners) is not clear to me. (Why would the fact that the listeners are asynchronous matter?) If it's an unnecessary detail (as seems likely), let's remove it. PR-URL: #36117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing text about processes not responding is unclear, at least to
me. Suggestions for clarification welcome, but I think the best thing
might be to state that the process may stop responding and leave it at
that. The explanantion (about asynchronous listeners) is not clear to
me. (Why would the fact that the listeners are asynchronous matter?) If
it's an unnecessary detail (as seems likely), let's remove it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes