Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: add support for AbortSignal to http2Session.request #36070

Closed
wants to merge 9 commits into from
Closed

http2: add support for AbortSignal to http2Session.request #36070

wants to merge 9 commits into from

Commits on Nov 21, 2020

  1. http2: add support for AbortSignal to http2Session.request 

    - Add support
- Add test
- Docs once PR is up
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    ba7f38b View commit details
    Browse the repository at this point in the history

  2. http2: Document AbortSignalSupport

    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    aec2c2b View commit details
    Browse the repository at this point in the history

  3. http2: Fix lint errors

    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    a88f87b View commit details
    Browse the repository at this point in the history

  4. http2: Remove redundant empty line in docs 

    - As per code review comment nodejs#36070 (comment)

Co-authored-by: Antoine du Hamel <[email protected]>
    @MadaraUchiha @aduh95
    MadaraUchiha and aduh95 committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    90ab360 View commit details
    Browse the repository at this point in the history

  5. http2: Use existing signal constant 

    - As per code review comment nodejs#36070 (comment)
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    2cd337e View commit details
    Browse the repository at this point in the history

  6. http2: Goodify test 

    - Remove redundant socket check
- Add assertion that AbortSignal event listener gets added then removed.
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    05f68a2 View commit details
    Browse the repository at this point in the history

  7. http2: Abort calls destroy with an AbortError 

    - Builds on nodejs#36048 and nodejs#36084
- Modify test to verify this fact
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    dc99724 View commit details
    Browse the repository at this point in the history

  8. http2: Update documentation 

    - Calling abort no longer behaves like .destroy()
- Fix linting errors
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    3d5177d View commit details
    Browse the repository at this point in the history

  9. http2: Abort immediately if passed an already aborted signal 

    - Also add test to that effect
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    9aca7c4 View commit details
    Browse the repository at this point in the history