net: Fix invalid write after end error #36043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Don't error if not ended. Fixes: nodejs#36029
ronag
force-pushed
the
net-write-after-end-no-half-open
branch
from
4c50922
to
1f73c8a
Compare
aduh95
reviewed
Nov 8, 2020
mscdex
reviewed
Nov 8, 2020
mscdex
reviewed
Nov 8, 2020
Co-authored-by: Antoine du Hamel <[email protected]>
mcollina
approved these changes
Nov 9, 2020
|
that's semver-major, so no. |
|
Thanks @mscdex! |
|
The test-stream-transform-end.js test file added here is timing out in GitHub CI. |
lpinca
reviewed
Nov 9, 2020
ronag
added
author ready
lpinca
reviewed
Nov 9, 2020
lpinca
approved these changes
Nov 9, 2020
github-actions
bot
removed
the
request-ci
ronag
force-pushed
the
net-write-after-end-no-half-open
branch
from
61d67ad
to
a0ea1b0
Compare
github-actions
bot
removed
the
request-ci
ronag
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/36043 ✔ Done loading data for nodejs/node/pull/36043 ----------------------------------- PR info ------------------------------------ Title net: Fix invalid write after end error (#36043) Author Robert Nagy (@ronag) Branch ronag:net-write-after-end-no-half-open -> nodejs:master Labels author ready, dont-land-on-v10.x, dont-land-on-v12.x, dont-land-on-v14.x, net Commits 8 - net: Fix invalid write after end error - fixup - Update lib/net.js - fixup - fixup - fixup - fixup - fixup Committers 2 - Robert Nagy - GitHub PR-URL: https://github.com/nodejs/node/pull/36043 Fixes: https://github.com/nodejs/node/issues/36029 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36043 Fixes: https://github.com/nodejs/node/issues/36029 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-10T10:34:15Z: https://ci.nodejs.org/job/node-test-pull-request/34279/ - Querying data for job/node-test-pull-request/34279/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sun, 08 Nov 2020 18:57:57 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36043#pullrequestreview-525942020 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36043#pullrequestreview-526614630 ✖ This PR needs to wait 1 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/356263944 |
github-actions
bot
added
the
commit-queue-failed
aduh95
added
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/36043 ✔ Done loading data for nodejs/node/pull/36043 ----------------------------------- PR info ------------------------------------ Title net: Fix invalid write after end error (#36043) Author Robert Nagy (@ronag) Branch ronag:net-write-after-end-no-half-open -> nodejs:master Labels author ready, commit-queue, dont-land-on-v10.x, dont-land-on-v12.x, dont-land-on-v14.x, net Commits 8 - net: Fix invalid write after end error - fixup - Update lib/net.js - fixup - fixup - fixup - fixup - fixup Committers 2 - Robert Nagy - GitHub PR-URL: https://github.com/nodejs/node/pull/36043 Fixes: https://github.com/nodejs/node/issues/36029 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36043 Fixes: https://github.com/nodejs/node/issues/36029 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-10T17:01:28Z: https://ci.nodejs.org/job/node-test-pull-request/34279/ - Querying data for job/node-test-pull-request/34279/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sun, 08 Nov 2020 18:57:57 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36043#pullrequestreview-525942020 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36043#pullrequestreview-526614630 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/356556511 |
github-actions
bot
added
the
commit-queue-failed
|
Landed in f7f0a6a |
aduh95
pushed a commit
that referenced
this pull request
Nov 10, 2020
Don't error if not ended. Fixes: #36029 PR-URL: #36043 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Don't error if not ended. Fixes: #36029 PR-URL: #36043 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't error if not ended.
Fixes: #36029
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes