Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: make nodeTiming a first-class object #35977

Closed
wants to merge 5 commits into from
Closed

perf_hooks: make nodeTiming a first-class object #35977

wants to merge 5 commits into from

Commits on Nov 5, 2020

  1. perf_hooks: make nodeTiming a first-class object 

    Render all properties of nodeTiming enumerable
so JSON.stringify and Object.keys can access them

Fixes: nodejs#35936
    @mmomtchev
    mmomtchev committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    e0b8f00 View commit details
    Browse the repository at this point in the history

  2. perf-hooks: Make nodeTiming a first-class object 

    Improve readability as per @aduh95 suggestion

Refs: nodejs#35977
    @mmomtchev
    mmomtchev committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    7d64d79 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. perf_hooks: make nodeTiming a first-class object 

    Transform the static values to plain properties
(@addaleax review)

Refs: nodejs#35977
    @mmomtchev
    mmomtchev committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    170242b View commit details
    Browse the repository at this point in the history

  2. perf_hooks: make nodeTiming a first-class object 

    Render all properties configurable
(@addaleax review)

nodejs#35977
    @mmomtchev
    mmomtchev committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    166f6b3 View commit details
    Browse the repository at this point in the history

  3. perf_hooks: make nodeTiming a first-class object 

    Render all properties of nodeTiming enumerable
so JSON.stringify and Object.keys can access them

Refs: nodejs#35977
    @mmomtchev
    mmomtchev committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    778f60b View commit details
    Browse the repository at this point in the history