tools: don't print gold linker warning w/o flag #35955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
github-actions
bot
removed
the
request-ci
|
I think you meant |
joyeecheung
reviewed
Nov 4, 2020
MylesBorins
force-pushed
the
limit-configure-section-file
branch
from
31563ac
to
c275e6d
Compare
|
@joyeecheung I opted to instead surpress the warning if the flag hasn't been passed. Thoughts? |
MylesBorins
changed the title
crypt096
approved these changes
Nov 4, 2020
Trott
added
the
python
joyeecheung
approved these changes
Nov 5, 2020
richardlau
approved these changes
Nov 5, 2020
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Nov 6, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: nodejs#35872
MylesBorins
force-pushed
the
limit-configure-section-file
branch
from
c275e6d
to
9d48454
Compare
|
don't know what's going on with CI, all failures unrelated. Rebasing against master and trying again. For those who have signed off already there have been 0 changes to the change since the reviewes |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Nov 7, 2020
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in cef1444...115722b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently configure_section_file is called even if the appropriate
flag has not been passed which is causing a warning to be printed
on all calls to configure without the flag.
Only call configure_section_file if
--limit-configure-section-filehas been passed to configure.
Fixes: #35872