tools,doc: bump remark to 13.0.0 for markdown linter rollup #35905
Conversation
|
Review requested:
|
nodejs-github-bot
added
c++
|
All those disable comments suggest that remark should maybe ignore tables or have an option for that |
|
https://github.com/remarkjs/remark/releases/tag/13.0.0 The changelog says that for tables we need |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Oops nope, I'm wrong.
And oops nope, I'm wrong here too. Will get GFM enabled. Might involve updating remark-preset-lint-node though. |
|
This is blocked on #35934. |
|
@targos Your comments have been addressed. While the comments were spot-on, unfortunately they also mean this will now fail until:
Those four things must happen in that order. |
|
OK, all done. PTAL, especially @targos! |
PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 1a29c09...1bc1f84 |
PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update [email protected], [email protected] and other dependencies in the lint-md rollup. PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update [email protected], [email protected] and other dependencies in the lint-md rollup. PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Update [email protected], [email protected] and other dependencies in the lint-md rollup. PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes