Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "console: rename argument of time and timeEnd" #3590

Conversation

silverwind
Copy link
Contributor

The argument name in the documentation was changed to match MDN in 8c043c1, but as it turns out the argument is actually called label in the console spec. I'll fix this on MDN soon after this commit lands.

cc: @targos @aks-

Turns out the argument is actually called label in the console spec,
while being wrongly named on MDN. A correction to MDN will follow.

This reverts commit 8c043c1.
@silverwind silverwind added doc Issues and PRs related to the documentations. console Issues and PRs related to the console subsystem. labels Oct 29, 2015
@targos
Copy link
Member

targos commented Oct 29, 2015

LGTM

@domenic
Copy link
Contributor

domenic commented Oct 30, 2015

There is no real console spec (that repo is not what is implemented in browsers), so I'm not sure this buys you anything. If you are really interested you could try doing console.time.toString() in a variety of browsers and seeing what they say...

@targos
Copy link
Member

targos commented Oct 30, 2015

@domenic do you have a trick to see the actual code instead of function time() { [native code] } ?

@domenic
Copy link
Contributor

domenic commented Oct 30, 2015

Well you can look at the source, for the open source browsers (i.e. not Edge). But parameters will be shown anyway, so your result indicates that that browser doesn't give the parameters any names at all.

@jasnell
Copy link
Member

jasnell commented Nov 3, 2015

LGTM but don't see it as a priority

silverwind added a commit that referenced this pull request Nov 10, 2015
Turns out the argument is actually called label in the console spec,
while being wrongly named on MDN. This reverts commit
8c043c1.

MDN has been updated in:

https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd$compare?locale=en-US&to=947893&from=918571
https://developer.mozilla.org/en-US/docs/Web/API/Console/time$compare?locale=en-US&to=947891&from=896987

PR-URL: #3590
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@silverwind
Copy link
Contributor Author

Landed in 9aee2c0.

@silverwind silverwind closed this Nov 10, 2015
silverwind added a commit that referenced this pull request Nov 11, 2015
Turns out the argument is actually called label in the console spec,
while being wrongly named on MDN. This reverts commit
8c043c1.

MDN has been updated in:

https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd$compare?locale=en-US&to=947893&from=918571
https://developer.mozilla.org/en-US/docs/Web/API/Console/time$compare?locale=en-US&to=947891&from=896987

PR-URL: #3590
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
@MylesBorins
Copy link
Contributor

No need for this to land on lts as 8c043c1 never landed being part of a semver-major change

@MylesBorins
Copy link
Contributor

I documented the process of coming to this conclusion on twitter if you wish to find out more

https://twitter.com/thealphanerd/status/666385833696489473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants