build,tools: GitHub Actions: use Node.js Fermium #35840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
gengjiawen
approved these changes
Oct 28, 2020
Trott
approved these changes
Oct 28, 2020
crypt096
approved these changes
Oct 28, 2020
aduh95
added
author ready
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35840 ✔ Done loading data for nodejs/node/pull/35840 ----------------------------------- PR info ------------------------------------ Title build,tools: GitHub Actions: use Node.js Fermium (#35840) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:gh-actions-node-14 -> nodejs:master Labels author ready, meta Commits 1 - build,tools: GitHub Actions: use Node.js Fermium Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/35840 Reviewed-By: Jiawen Geng Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35840 Reviewed-By: Jiawen Geng Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-28T08:38:48Z: https://ci.nodejs.org/job/node-test-pull-request/33896/ - Querying data for job/node-test-pull-request/33896/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Tue, 27 Oct 2020 23:28:32 GMT ✔ Approvals: 2 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/35840#pullrequestreview-518266606 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35840#pullrequestreview-518286573 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 35840 From https://github.com/nodejs/node * branch refs/pull/35840/merge -> FETCH_HEAD ✔ Fetched commits as 1da672994ac2..8aff91fb5ac9 -------------------------------------------------------------------------------- [master b9d11b2430] build,tools: GitHub Actions: use Node.js Fermium Author: Antoine du Hamel Date: Wed Oct 28 00:26:46 2020 +0100 4 files changed, 10 insertions(+), 4 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- build,tools: GitHub Actions: use Node.js Fermium Commit Queue action: https://github.com/nodejs/node/actions/runs/337539246 |
github-actions
bot
added
the
commit-queue-failed
PR-URL: nodejs#35840 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Suggestion to fix the commit message: |
aduh95
force-pushed
the
gh-actions-node-14
branch
from
8aff91f
to
876d816
Compare
|
Landed in 876d816 |
Oh that would have been better! Sorry I didn't see your comment in time. |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35840 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35840 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35840 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35840 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes