Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update acorn to v8.0.4 #35791

Closed
wants to merge 1 commit into from
Closed

deps: update acorn to v8.0.4 #35791

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 24, 2020

This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

@targos
deps: update acorn to v8.0.4
7338e39 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/community-committee
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 24, 2020
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33846/

Trott
Trott reviewed Oct 24, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2020
mcollina
mcollina approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jasnell
jasnell approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉 🥳 🎉 🥳 🎉

@jasnell
Copy link
Member

jasnell commented Oct 26, 2020

Do you know if it also supports the new logical operators? e.g. ??= and !!= etc

@targos
Copy link
Member Author

targos commented Oct 26, 2020

@jasnell I think they are supported, but only with ecmaVersion: 2021. I would suggest to enable it in a separate PR so this one can be cherry-picked to v14.

bnb
bnb approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the CommComm perspective since it's requested by the bot. Cursory glance at the markdown content + License changes, plus an RSLGTM on code since a lot of folks I trust to do the work there have approved.

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actions
Copy link
Contributor

Landed in ed5e539...16b2bc0

@github-actions github-actions bot closed this Oct 27, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
@targos @nodejs-github-bot
deps: update acorn to v8.0.4
16b2bc0 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos deleted the update-acorn branch October 27, 2020 05:35
@richardlau richardlau mentioned this pull request Oct 27, 2020
Closed
targos added a commit that referenced this pull request Nov 3, 2020
@targos
deps: update acorn to v8.0.4
52a77db 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@targos @BethGriggs
deps: update acorn to v8.0.4
bfd30cc 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@targos @BethGriggs
deps: update acorn to v8.0.4
dc5fdb8 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
2b6dd9c 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@targos @BethGriggs
deps: update acorn to v8.0.4
7367e6c 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a2f9a70 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a150926 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@codebytere codebytere codebytere approved these changes

@watilde watilde watilde approved these changes

@Trott Trott Trott approved these changes

@bnb bnb bnb approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @jasnell @mcollina @bnb @Trott @watilde @codebytere @cjihrig @gengjiawen