console: use more primordials #35734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
console
aduh95
added
backport-requested-v12.x
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
|
Why am I getting |
|
My guess is that the method is not available to primordials because it can be disabled in V8 with |
This comment has been minimized.
This comment has been minimized.
Interesting. Well I guess we'll have to refrain from using it in node core for the time being then… |
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
|
@nodejs/console Can you review this please? |
aduh95
force-pushed
the
console-refactor-primordials
branch
from
446aa98
to
f2c9f81
Compare
github-actions
bot
removed
the
request-ci
PR-URL: nodejs#35734 Reviewed-By: Rich Trott <[email protected]>
aduh95
force-pushed
the
console-refactor-primordials
branch
from
f2c9f81
to
1f6ca18
Compare
|
Landed in 1f6ca18 |
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport requested because optional chaining is not available on Node.js 12.No need for optional chaining after all 😅Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes