ci(automation): automatically update licenses weekly / on-demand #35712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Trott
approved these changes
Oct 20, 2020
watilde
approved these changes
Oct 20, 2020
PR-URL: nodejs#35712 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Trott
force-pushed
the
bnb/add-license-updater-action
branch
from
f53b207
to
8f47e69
Compare
|
Landed in 8f47e69 |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35712 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35712 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35712 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35712 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #35577, I brought up that the license updating could be automated with relative ease using @gr2m's create-or-update-pull-request-action. I spent some time today between work getting this working. You can find an example in bnb#2 of how it works - specifically, note that the first commit (my commit!) removes the line that #335577 added, and then the action adds it back once it's done.
The action currently is set to allow for two triggers:
workflow_dispatchtrigger. This is for the case where someone from the TSC or core knows there's an update and would prefer to not wait.Checklist