-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Updates for remark v13 #35647
Merged
Merged
doc: Updates for remark v13 #35647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
doc
Issues and PRs related to the documentations.
labels
Oct 14, 2020
nschonni
commented
Oct 14, 2020
doc/api/dns.md
Outdated
@@ -560,10 +560,12 @@ be an array of objects with the following properties: | |||
added: v0.1.27 | |||
--> | |||
|
|||
<!--lint disable no-undefined-references list-item-bullet-indent--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a small conflict with the v12 and v13. The list-item-bullet-indent
can be removed once upgraded to v13
aduh95
approved these changes
Oct 14, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 15, 2020
watilde
approved these changes
Oct 15, 2020
Trott
approved these changes
Oct 15, 2020
Landed in 26fcdb6...1a29c09 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 3, 2020
Addresses table-cell-padding rule issues PR-URL: nodejs#35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
pushed a commit
that referenced
this pull request
Nov 3, 2020
The manual links appear to be specific workarounds, so just ignore them PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Addresses table-cell-padding rule issues PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
The manual links appear to be specific workarounds, so just ignore them PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Not an issue with v13 remark, but seems to be a glitch in the disabled lines in v12 conflicting. PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Addresses table-cell-padding rule issues PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
The manual links appear to be specific workarounds, so just ignore them PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Not an issue with v13 remark, but seems to be a glitch in the disabled lines in v12 conflicting. PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Addresses table-cell-padding rule issues PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
The manual links appear to be specific workarounds, so just ignore them PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Not an issue with v13 remark, but seems to be a glitch in the disabled lines in v12 conflicting. PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Addresses table-cell-padding rule issues PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
The manual links appear to be specific workarounds, so just ignore them PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Not an issue with v13 remark, but seems to be a glitch in the disabled lines in v12 conflicting. PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nodejs/remark-preset-lint-node#159
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes