-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-webcrypto-encrypt-decrypt-aes flaky #35587
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears to be flaky only on rhe17-390x. Will be investigating refs: nodejs#35586
jasnell
added
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
crypto
Issues and PRs related to the crypto subsystem.
labels
Oct 10, 2020
cc @nodejs/platform-s390 |
Trott
approved these changes
Oct 11, 2020
Please 👍🏻 to fast-track |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 11, 2020
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 13, 2020
mcollina
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm + fast track
jasnell
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 13, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 13, 2020
Landed in f7ed5f4...efe60a5 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2020
Appears to be flaky only on rhe17-390x. Will be investigating refs: #35586 PR-URL: #35587 Refs: #35586 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
Appears to be flaky only on rhe17-390x. Will be investigating refs: #35586 PR-URL: #35587 Refs: #35586 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Appears to be flaky only on rhe17-390x. Will be investigating refs: nodejs#35586 PR-URL: nodejs#35587 Refs: nodejs#35586 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
fast-track
PRs that do not need to wait for 48 hours to land.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to be flaky only on rhe17-390x. Will be investigating
refs: #35586
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes