[v12.x backport] CJS exports detection #35405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
guybedford
force-pushed
the
12-cjs-export-detection
branch
3 times, most recently
from
3627a5a
to
0e3380a
Compare
GeoffreyBooth
approved these changes
Oct 1, 2020
|
@guybedford can you rebase this? |
PR-URL: nodejs#35249 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#35426 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Myles Borins <[email protected]>
guybedford
force-pushed
the
12-cjs-export-detection
branch
from
0e3380a
to
0708932
Compare
|
@codebytere sure, thanks for looking into this, I've rebased the commits. |
codebytere
approved these changes
Oct 2, 2020
|
Landed in 2f3ffc0...5357a05 |
codebytere
pushed a commit
that referenced
this pull request
Oct 4, 2020
PR-URL: #35249 Backport-PR-URL: #35405 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Oct 4, 2020
PR-URL: #35426 Backport-PR-URL: #35405 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
@codebytere we need to also include #35483 and preferably #35501 as well. When is the 12.x release planned for? We may want to bump some of the modules changes that only came out last week if we can have them bake a bit longer. |
|
_@MylesBorins it's slated for tues 10/6 - what are your thoughts for which to bump? we could either
|
|
There are a bunch of modules backports that were part of this and the prior PR that have not been on Current for two weeks (they went out last week). Even if we bump a week some of the fixes haven't gone out yet. Are we still planning one more minor before maintenance? |
7 tasks
3 tasks
|
Closing in favor of #35757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the CJS exports detection from #35249 and the error message adjustments from #35426 for 12.x.
This PR is based to the modules backports PR at #35385 so should land after that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes