-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10.x] build: expose napi_build_version variable #35266
[v10.x] build: expose napi_build_version variable #35266
Conversation
Expose `napi_build_version` to allow `node-gyp` to make it available for building native addons. Fixes: nodejs/node-gyp#1745 Refs: nodejs/abi-stable-node#371 PR-URL: nodejs#27835 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
bf373c5
to
248df1b
Compare
@NickNaso can you please link the issue that has recently cropped up because we forgot to backport this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this seems very low risk and we had an issue reported where a N-API module failed to build because it could not check the value.
Hi everybody sorry for the late. |
Are there likely to be any other n-api related things that need to land on 10.x? We don't have any regular scheduled releases for 10.x now it is in maintenance1 so I'm trying to gauge how much content we'll have to put out in a release. 1To clarify, I'm okay with this landing on 10.x, just working through the logistics of how we actually get it into what release. |
@richardlau the PR that marks N-API 7 as stable must still land. |
Thanks. FWIW we discussed the plan for Node.js v10.x at the most recent Release WG meeting (nodejs/Release#614) and the current idea is to look to do a release in about a month's time. |
Expose `napi_build_version` to allow `node-gyp` to make it available for building native addons. Fixes: nodejs/node-gyp#1745 Refs: nodejs/abi-stable-node#371 PR-URL: #27835 Backport-PR-URL: #35266 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Landed in b83f9a5. |
Expose
napi_build_version
to allownode-gyp
to make itavailable for building native addons.
Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax
Reviewed-By: @gabrielschulhof
Reviewed-By: @lpinca
Reviewed-By: @richardlau
Reviewed-By: @mhdawson
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes