Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix incorrectly marked Buffer in quic.md #35075

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 6, 2020

Angle brackets are being used where curly brackets are intended.

Checklist

@Trott Trott requested a review from a team September 6, 2020 07:42
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 6, 2020
@Trott
Copy link
Member Author

Trott commented Sep 6, 2020

Before (where the <Buffer> disappears because it is interpreted as an HTML tag:
image

After:
image

@Trott
Copy link
Member Author

Trott commented Sep 8, 2020

Landed in ccdd1bd

@Trott Trott merged commit ccdd1bd into nodejs:master Sep 8, 2020
@Trott Trott deleted the quic-curly branch September 8, 2020 13:10
Angle brackets are being used where curly brackets are intended.

PR-URL: nodejs#35075
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Angle brackets are being used where curly brackets are intended.

PR-URL: nodejs#35075
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants