Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use present tense in events.md #35068

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 5, 2020

Present tense should be default choice. It is usually easier to read and
understand.

Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 5, 2020
@Trott
Copy link
Member Author

Trott commented Sep 7, 2020

Landed in c4b3b23

@Trott Trott merged commit c4b3b23 into nodejs:master Sep 7, 2020
@Trott Trott deleted the events-present branch September 7, 2020 15:01
Present tense should be default choice. It is usually easier to read and
understand.

Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs

PR-URL: nodejs#35068
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Present tense should be default choice. It is usually easier to read and
understand.

Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs

PR-URL: #35068
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@richardlau richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Present tense should be default choice. It is usually easier to read and
understand.

Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs

PR-URL: #35068
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Present tense should be default choice. It is usually easier to read and
understand.

Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs

PR-URL: nodejs#35068
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants