doc: remove style for empty links #35034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Trott as you are the one who suggested this. |
Trott
approved these changes
Sep 4, 2020
|
I imagine this may not be an issue now that the |
DerekNonGeneric
approved these changes
Sep 4, 2020
Trott
force-pushed
the
fix-doc-empty-links
branch
from
d543696
to
ec5958f
Compare
|
Landed in ec5958f |
PR-URL: nodejs#35034 Refs: nodejs#34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
|
Alas, this causes visited links to show in a different color.
Revert since we're eliminating @nodejs/website |
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35034 Refs: nodejs#34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the side effect when hovering over empty anchor links:
It appears on a few pages:
deprecations.htmlEDIT: Taken care of in doc: properly mark up deprecation anchors #34955Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: #34955