doc: fix certificate display in tls doc #35032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
This comment has been minimized.
This comment has been minimized.
|
Unfortunately this regresses the markdown view: After: I suppose on balance most readers will be reading the HTML docs. |
My sense has always been that markdown is an authoring format for us but HTML is our publishing format. So, for example, we have many broken links in the markdown, but they work just fine in the HTML. Although something that displayed correctly in both places would be great. |
|
Changing the language string from
|
richardlau
approved these changes
Sep 3, 2020
MrHeer
approved these changes
Sep 4, 2020
|
@nodejs/website |
nschonni
approved these changes
Sep 5, 2020
addaleax
approved these changes
Sep 5, 2020
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: nodejs#35032 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in a05f672 |
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: #35032 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: #35032 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: #35032 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: #35032 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: nodejs#35032 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one context,
<Buffer>was being interpretted as an HTML tag and notdisplayed.
Checklist