Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: remove undefined variable #35007

Merged
merged 1 commit into from
Sep 3, 2020
Merged

quic: remove undefined variable #35007

merged 1 commit into from
Sep 3, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 1, 2020 •
edited
Loading

The reason variable never gets defined. It's use in a template string
will always end up as the string 'undefined'.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott requested a review from a team September 1, 2020 05:28
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 1, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32998/

@Trott Trott merged commit 449f73e into nodejs:master Sep 3, 2020
@Trott
quic: remove undefined variable
449f73e 
The `reason` variable never gets defined. It's use in a template string
will always end up as the string `'undefined'`.

PR-URL: nodejs#35007
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member Author

Trott commented Sep 3, 2020

Landed in 449f73e

@Trott Trott deleted the quic-fix branch September 3, 2020 12:26
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
quic: remove undefined variable
64c12b1 
The `reason` variable never gets defined. It's use in a template string
will always end up as the string `'undefined'`.

PR-URL: nodejs#35007
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig @trivikr @MrHeer