Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise commit-queue.md #35006

Merged
merged 1 commit into from
Sep 3, 2020
Merged

doc: revise commit-queue.md #35006

merged 1 commit into from
Sep 3, 2020
+9 −9

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 1, 2020

Make minor fixes to the text.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 1, 2020
@Trott Trott changed the title doc: revise commit-queu.md doc: revise commit-queue.md Sep 1, 2020
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 1, 2020
@Trott Trott merged commit 69b8a39 into nodejs:master Sep 3, 2020
@Trott
Copy link
Member Author

Trott commented Sep 3, 2020

Landed in 69b8a39

@Trott Trott deleted the cq branch September 3, 2020 12:27
@Trott
doc: revise commit-queue.md
69b8a39 
Make minor fixes to the text.

PR-URL: nodejs#35006
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@Trott @richardlau
doc: revise commit-queue.md
f1217d6 
Make minor fixes to the text.

PR-URL: #35006
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: revise commit-queue.md
e8399ef 
Make minor fixes to the text.

PR-URL: #35006
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: revise commit-queue.md
8cc7a73 
Make minor fixes to the text.

PR-URL: #35006
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: revise commit-queue.md
f4c2252 
Make minor fixes to the text.

PR-URL: nodejs#35006
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@lundibundi lundibundi lundibundi approved these changes

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@targos targos targos approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @yosuke-furukawa @lpinca @watilde @targos @mmarchini @richardlau @lundibundi @Flarna @nodejs-github-bot